gha: update to use aws sm #18857
Merged
gha: update to use aws sm #18857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to resolve warning: > Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3.
Looks like this worklfow is not needed because it has been disabled for over 1 year: https://github.com/redpanda-data/redpanda/actions/workflows/old-backports.yml
It does not look like this worklfow is used because no history of it running: https://github.com/redpanda-data/redpanda/actions/workflows/packages-created.yml
No history of workflow runs since disabled: https://github.com/redpanda-data/redpanda/actions/workflows/render-draft-release-notes.yml
Disabled worklfow has no history of workflow run: https://github.com/redpanda-data/redpanda/actions/workflows/slack-messages.yml
|
|
To address warning message: > Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4.
|
/dt |
clee
approved these changes
Jun 10, 2024
| uses: aws-actions/aws-secretsmanager-get-secrets@v2 | ||
| with: | ||
| secret-ids: | | ||
| ,sdlc/prod/github/jira |
There was a problem hiding this comment.
I assume the empty list before the leading comma means "all IDs" or something? Maybe a comment here would be useful.
There was a problem hiding this comment.
that's just how the plugin is documented to be used for environmental variable naming with blank aliases:
If you set
parse-json-secrets: trueand enter a blank alias, followed by a comma and then the secret ID, the action names the environment variable the same as the parsed JSON keys.
|
/backport v24.1.x |
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Jun 10, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://redpandadata.atlassian.net/browse/PESDLC-1345
github secrets for this repo have been migrated to aws secretsmanager. this PR uses gha aws-actions/aws-secretsmanager-get-secrets to access the secrets.
this PR also removes unused workflows to reduce number of used secrets:
Backports Required
Release Notes